NEC-373: An Excalidraw hardness round failed with a just-inserted image's place repaired again and again (seed 779315737, not reproduced) #338
No reviewers
Labels
No labels
area:docs
area:identity
area:ops
area:plugin
area:server
channel:community
channel:direct
channel:owned
channel:press
channel:social
dependencies
e2ee-constrained
gate:at-ga
gate:pre-ga
marketing
parity
relay:absent
relay:planned
relay:requested
relay:supported
risk:additive
risk:contract
risk:none
security
usability
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Nectenda/nectenda!338
Loading…
Reference in a new issue
No description provided.
Delete branch "worktree-nec-373-an-excalidraw-hardness-round-failed-with"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Task: NEC-373 — https://projectron.nerchure.com/tasks/395
Two shapes added at once, one per vault, can take one fractional index. The drawing's file broke that tie by each shape's position in the file it came from, but Excalidraw breaks it by id. So a vault working through its file and a vault drawing live each re-placed a different shape, onto the same new index, and each repair was a version the other drew and repaired again. This failed the Excalidraw hardness run (seed 779315737). Proven before the fix: a unit test of the writer's order; the excalidraw-tie probe against real Excalidraw 2.29.0 and 2.27.3; and a two-vault e2e test with live sync off in one vault, which saw 31 repairs in 20 s. The file now writes a tie by id (SAFE-A53); elements with no index keep their file order. The same e2e test now sees at most one repair, and both files then hold the two shapes at two places, on one version each. A repair's log line now names its place before and after. Local gate passed; Excalidraw hardness run green for 90 min (seed 779315737 for 60 min, 331 rounds; seed 528014309 for 30 min, 167 rounds). Tested by the user in their vaults before this PR.
Spec:
docs/changes/NEC-373-excalidraw-tie-order/spec.mdChangelog
Fixed a drawing open in two vaults repeatedly re-ordering a shape added in both at once, when one of them was not syncing the drawing live.