Run the directory's directive-comment rules in the lint gate #332

Merged
cruelacid merged 1 commit from worktree-nec-directive-descriptions into main 2026-10-30 17:12:13 +00:00
Owner

The community directory's branch review of 0.6.0 (public main 3dfb5d6) failed on one Error:

Unexpected undescribed directive comment. Include descriptions to explain why the comment is necessary.
packages/plugin/src/text-hash.ts:101

The line was /* eslint-enable no-fallthrough */ with no -- reason.

The directory's recommended config turns on four eslint-comments/* rules. Our gate picks the directory's rules one at a time, and it had taken none of these four. This PR follows docs/releasing.md: add the rules, confirm they reproduce at the reported site, then fix the site.

  • eslint.config.mjs: adds require-description, no-unlimited-disable, disable-enable-pair and no-restricted-disable to the published-packages block, with the directory's own options.
  • The rule reproduced as exactly one error, at text-hash.ts:101, before the fix. After the fix: 0 errors and 8 warnings. Those are the registered ones, and the scorecard matches lint-register.json one for one.
  • text-hash.ts:101: the enable directive now carries a description.
  • docs/releasing.md: records this second slip of the gate's calibration.
  • package.json and the lockfile: @eslint-community/eslint-plugin-eslint-comments is pinned at 4.8.1, the version eslint-plugin-obsidianmd already pulled in. pnpm also pruned an unreferenced @typescript-eslint/parser 8.70.0 chain. --frozen-lockfile passes.

The local gate and build-mirror --check pass.

This blocks NEC-362 (0.6.0). Once it is merged, the release goes back to step 6: re-push the public main and scan it again.

Task: NEC-368

Changelog

NONE

🤖 Generated with Claude Code

https://claude.ai/code/session_01P5JXvAgQ27c4dMFDB2Wu5B

The community directory's branch review of 0.6.0 (public `main` 3dfb5d6) failed on one Error: > Unexpected undescribed directive comment. Include descriptions to explain why the comment is necessary. > packages/plugin/src/text-hash.ts:101 The line was `/* eslint-enable no-fallthrough */` with no `-- reason`. The directory's recommended config turns on four `eslint-comments/*` rules. Our gate picks the directory's rules one at a time, and it had taken none of these four. This PR follows `docs/releasing.md`: add the rules, confirm they reproduce at the reported site, then fix the site. - `eslint.config.mjs`: adds `require-description`, `no-unlimited-disable`, `disable-enable-pair` and `no-restricted-disable` to the published-packages block, with the directory's own options. - The rule reproduced as exactly one error, at `text-hash.ts:101`, before the fix. After the fix: 0 errors and 8 warnings. Those are the registered ones, and the scorecard matches `lint-register.json` one for one. - `text-hash.ts:101`: the enable directive now carries a description. - `docs/releasing.md`: records this second slip of the gate's calibration. - `package.json` and the lockfile: `@eslint-community/eslint-plugin-eslint-comments` is pinned at 4.8.1, the version `eslint-plugin-obsidianmd` already pulled in. pnpm also pruned an unreferenced `@typescript-eslint/parser` 8.70.0 chain. `--frozen-lockfile` passes. The local gate and `build-mirror --check` pass. This blocks NEC-362 (0.6.0). Once it is merged, the release goes back to step 6: re-push the public `main` and scan it again. Task: NEC-368 ## Changelog NONE 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01P5JXvAgQ27c4dMFDB2Wu5B
Run the directory's directive-comment rules in the lint gate
All checks were successful
Release note / release-note (pull_request) Successful in 19s
CI / build (pull_request) Successful in 6m42s
CI / e2e (pull_request) Successful in 15m19s
CI / promote (pull_request) Has been skipped
CI / build (push) Successful in 6m54s
CI / e2e (push) Successful in 15m8s
CI / promote (push) Successful in 34s
ff8bc752fa
The community directory's branch review of 0.6.0 failed on an Error:
an eslint-enable directive in text-hash.ts with no description. The
directory's recommended config turns on four eslint-comments rules,
and the gate, which picks rules one at a time, had taken none of them.
All four now run on the published packages, with the directory's
options. require-description reproduced at text-hash.ts:101 before the
line was given its reason.

pnpm also dropped an unreferenced @typescript-eslint/parser 8.70.0
chain from the lockfile when it added the plugin.

Task: NEC-368

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01P5JXvAgQ27c4dMFDB2Wu5B
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Nectenda/nectenda!332
No description provided.