NEC-353: Renovate's dev-dependency batch can move server production dependencies through the lockfile #326

Merged
nectenda-agent merged 3 commits from worktree-nec-353-renovates-dev-dependency-batch-can-move into main 2026-10-28 12:20:56 +00:00
Collaborator

Task: NEC-353 — https://projectron.nerchure.com/tasks/374

Renovate's automerged development batch of 26 Oct 2026 (e3005332) bumped only esbuild, but its regenerated pnpm-lock.yaml also moved the server's ws, yjs and lib0. renovate.json's "never automatically" rule for production dependencies matches the dependency type in the bumped package.json and cannot see the lockfile. On Renovate's pull requests, the required release-note job now diffs the lockfile's shipped closures (server, identity, shared, ops-common, the plugin, and deploy's bundled Kuma client), base against head. It fails until the description carries 'Production dependencies reviewed at <head sha>'. A new push changes the sha and invalidates the line. A replay on e3005332 flags ws, yjs, lib0 and socket.io-client. Not yet exercised end to end: this branch is not Renovate's, so the next Renovate pull request that touches the lockfile is the first real run.

Spec: docs/changes/NEC-353-renovate-lockfile-production-moves/spec.md

Also fixes NEC-358: The lockfile check does not see deploy's socket.io-client bundle, which runs on every host

Changelog

NONE

Task: NEC-353 — https://projectron.nerchure.com/tasks/374 Renovate's automerged development batch of 26 Oct 2026 (e3005332) bumped only esbuild, but its regenerated pnpm-lock.yaml also moved the server's ws, yjs and lib0. renovate.json's "never automatically" rule for production dependencies matches the dependency type in the bumped package.json and cannot see the lockfile. On Renovate's pull requests, the required release-note job now diffs the lockfile's shipped closures (server, identity, shared, ops-common, the plugin, and deploy's bundled Kuma client), base against head. It fails until the description carries 'Production dependencies reviewed at <head sha>'. A new push changes the sha and invalidates the line. A replay on e3005332 flags ws, yjs, lib0 and socket.io-client. Not yet exercised end to end: this branch is not Renovate's, so the next Renovate pull request that touches the lockfile is the first real run. Spec: `docs/changes/NEC-353-renovate-lockfile-production-moves/spec.md` Also fixes NEC-358: The lockfile check does not see deploy's socket.io-client bundle, which runs on every host ## Changelog NONE
Renovate's "never automatically" rule for production dependencies matches
the type in the package.json being bumped. It cannot see that the lockfile
it regenerates moved another workspace's production resolutions: on 26
October 2026 the automerged development batch bumped esbuild and also moved
the server's ws, yjs and lib0.

The release-note job now reads pnpm-lock.yaml on Renovate's pull requests,
diffs the production closure of every workspace that ships, base against
head, and fails until the description carries a review line naming the
head's exact sha. It is in that job because a person approves by editing the
description, which this job already re-runs on and branch protection
already requires.

Task: NEC-353

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013mxYJDCM5kgaBRtmbzMeDE
Two findings from review. A workspace on the list absent from both lockfiles
read as an empty closure on both sides, so a rename would have passed every
later pull request; it now throws, and a test holds the list against the
repository's own lockfile. And the stale-sha rule lived only in the CLI, where
no test could fail on it; it is now mayMerge, tested directly.

Task: NEC-353

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013mxYJDCM5kgaBRtmbzMeDE
Count deploy's bundled Kuma client as shipped in the lockfile check
All checks were successful
Release note / release-note (pull_request) Successful in 17s
CI / build (pull_request) Successful in 5m40s
CI / e2e (pull_request) Successful in 14m48s
CI / promote (pull_request) Has been skipped
c3ddbd17f8
install-deployer.sh bundles socket.io-client, a development dependency of
deploy, into kuma-maintenance.cjs, which every host runs on every deploy
holding the Kuma password. The check covered only workspaces' production
closures, so the automerged development batch could move that tree unseen,
and e3005332 did: socket.io-client 4.8.3 to 4.8.4. The list of what ships now
takes named bundled packages, followed through their production closure,
while deploy's other development tools stay out.

Task: NEC-353
Also-fixes: NEC-358

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013mxYJDCM5kgaBRtmbzMeDE
cruelacid force-pushed worktree-nec-353-renovates-dev-dependency-batch-can-move from c3ddbd17f8
All checks were successful
Release note / release-note (pull_request) Successful in 17s
CI / build (pull_request) Successful in 5m40s
CI / e2e (pull_request) Successful in 14m48s
CI / promote (pull_request) Has been skipped
to aa4131dac8
All checks were successful
Release note / release-note (pull_request) Successful in 16s
CI / build (pull_request) Successful in 6m1s
CI / e2e (pull_request) Successful in 14m54s
CI / promote (pull_request) Has been skipped
CI / build (push) Successful in 6m24s
CI / e2e (push) Successful in 14m59s
CI / promote (push) Successful in 33s
2026-10-28 12:04:53 +00:00
Compare
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Nectenda/nectenda!326
No description provided.