NEC-311: A failed backup outside the write is ignored, and content replaced with no copy #317
No reviewers
Labels
No labels
area:docs
area:identity
area:ops
area:plugin
area:server
channel:community
channel:direct
channel:owned
channel:press
channel:social
dependencies
e2ee-constrained
gate:at-ga
gate:pre-ga
marketing
parity
relay:absent
relay:planned
relay:requested
relay:supported
risk:additive
risk:contract
risk:none
security
usability
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Nectenda/nectenda!317
Loading…
Reference in a new issue
No description provided.
Delete branch "worktree-nec-311-a-failed-backup-outside-the-write-is-ign"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Task: NEC-311 — https://projectron.nerchure.com/tasks/330
When a backup copy made before overwriting a note or its shared document could not be written, the overwrite went ahead anyway, so content could be replaced with no copy kept. Now nothing is replaced until its copy is kept: the note and its document are left as they are, the user is told once, and the copy is retried.
Ride-alongs from the same work: NEC-330 (typing that could not be replayed at a bind is held until its copy can be kept), NEC-331 (properties are not rewritten before their copy is kept), NEC-332 (the Markdown hardness run resolves a raced copy whose path the log scrubbed), NEC-333 and NEC-334 (a note or structured file deleted here while sync was stopped stays deleted when sync stops again before the delete is carried out), and NEC-336 (Obsidian's copy of one pane over another, when two panes of a note change within ~30 ms, is no longer taken when the copied pane holds typing, so a collaborator's change is no longer deleted from every vault).
Verified locally: gate-local.sh passed at
b7ed7ddb(unit suites, lint, typecheck, mirror check, full container e2e). Markdown hardness 60 min on seed 1995616556, which failed at rounds 68 and 319 on main: 347 rounds passed. Canvas hardness 60 min on seed 536275601: 270 rounds passed. Each new rule mutation-checked; the NEC-336 e2e fails with the fix off.Spec:
docs/changes/NEC-311-copy-failed-outside-write/spec.mdAlso fixes NEC-333: A delete made here while stopped is forgotten when sync stops again before it is carried out
Also fixes NEC-334: A structured file's delete made here while stopped is forgotten when sync stops again before it is carried out
Also fixes NEC-336: A second pane's save deletes a collaborator's text with no copy, after a bind replays the other pane's typing
Changelog
A note or its shared document is no longer replaced when the backup copy made before replacing it cannot be written; you are told, and it retries.