Revert NEC-15's checkpoint writer until its stall is understood #152

Merged
nectenda-agent merged 1 commit from worktree-revert-nec-15 into main 2026-09-24 16:39:59 +01:00
Collaborator

Task: NEC-15 — https://projectron.nerchure.com/tasks/15

Reverts #145 (206d1f6 and b7e3271). #151 (the NEC-87 fix) landed on top of NEC-15 meanwhile and is independent of it; its only shared file is the generated docs/v1/conformance.md. So the result is exactly cdda616 plus #151. That was checked: git diff cdda616 HEAD equals git diff b7e3271 b9366a9 outside the generated file, and the conformance check passes. cdda616 is the last main that passed CI in full, and it is what eu1 and accounts are running.

Why. main's run on b7e3271 failed in build: checkpoints.test.ts › "past the compaction threshold, through the WebSocket path › keeps the earlier state recoverable" timed out at 5 s. It was a stall, not slowness: the server started at 15:05:51.19 and the test logged nothing more. The same commit passed on the PR's run, and 120 of 120 runs on the Mac under parallel load, so it is intermittent and unexplained. It stalls where the test drives the real threaded writer through a compaction, as production does, so it does not ship until someone has instrumented it.

Nothing to migrate back. Promote was skipped on b7e3271, and eu1 and accounts are on cdda616, so no production database ever carried #145's schema change.

Changelog: #145's entry must be dropped at the next cut. #145 carried "The server now keeps earlier versions of each note when it compacts edit history, instead of discarding them." Users never received it, so this revert is NONE, but scripts/changelog.mjs has no revert handling and would otherwise list #145.

Changelog

NONE

Task: NEC-15 — https://projectron.nerchure.com/tasks/15 Reverts #145 (206d1f6 and b7e3271). #151 (the NEC-87 fix) landed on top of NEC-15 meanwhile and is independent of it; its only shared file is the generated `docs/v1/conformance.md`. So the result is **exactly cdda616 plus #151**. That was checked: `git diff cdda616 HEAD` equals `git diff b7e3271 b9366a9` outside the generated file, and the conformance check passes. cdda616 is the last main that passed CI in full, and it is what eu1 and accounts are running. **Why.** main's run on b7e3271 failed in `build`: `checkpoints.test.ts` › "past the compaction threshold, through the WebSocket path › keeps the earlier state recoverable" timed out at 5 s. It was a **stall**, not slowness: the server started at 15:05:51.19 and the test logged nothing more. The same commit passed on the PR's run, and 120 of 120 runs on the Mac under parallel load, so it is intermittent and unexplained. It stalls where the test drives the real threaded writer through a compaction, as production does, so it does not ship until someone has instrumented it. **Nothing to migrate back.** Promote was skipped on b7e3271, and eu1 and accounts are on cdda616, so no production database ever carried #145's schema change. **Changelog: #145's entry must be dropped at the next cut.** #145 carried "The server now keeps earlier versions of each note when it compacts edit history, instead of discarding them." Users never received it, so this revert is NONE, but `scripts/changelog.mjs` has no revert handling and would otherwise list #145. ## Changelog NONE
cruelacid force-pushed worktree-revert-nec-15 from 1bd34ce05c
All checks were successful
CI / build (pull_request) Successful in 5m3s
CI / e2e (pull_request) Successful in 5m29s
CI / promote (pull_request) Has been skipped
Release note / release-note (pull_request) Successful in 14s
to b6b264de8e
All checks were successful
Release note / release-note (pull_request) Successful in 13s
CI / build (pull_request) Successful in 4m31s
CI / e2e (pull_request) Successful in 5m59s
CI / promote (pull_request) Has been skipped
Deploy site / deploy (push) Successful in 51s
CI / e2e (push) Successful in 4m27s
CI / build (push) Successful in 5m8s
CI / promote (push) Successful in 31s
2026-09-24 16:33:44 +01:00
Compare
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Nectenda/nectenda!152
No description provided.